[Merged by Bors] - Fix the windows build artifacts name #6351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the GOOS is equal to windows will force the value of EXE = .exe - Fix the windows build output
dsmello
requested review from
dshulyak,
fasmat,
poszu,
ivan4th and
acud
as code owners
jellonek
approved these changes
Sep 25, 2024
fasmat
approved these changes
Sep 25, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
## Motivation Fix the windows build output
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6351 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 312 312
Lines 34657 34657
=======================================
+ Hits 28328 28348 +20
+ Misses 4492 4475 -17
+ Partials 1837 1834 -3 ☔ View full report in Codecov by Sentry. |
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
## Motivation Fix the windows build output
poszu
reviewed
Sep 25, 2024
| @@ -27,6 +27,7 @@ ifeq ($(GOOS),windows) | |||
| platform := windows | |||
| export PATH := $(PATH):$(BIN_DIR) | |||
| CGO_LDFLAGS := $(CGO_LDFLAGS) -Wl,-Bstatic -lpthread -Wl,-Bdynamic | |||
| EXE := .exe | |||
There was a problem hiding this comment.
I removed this from this file because it was not used anywhere and I didn't notice it's used in the Makefile that includes it. For this reason, in my opinion, EXE should be defined in the Makefile which uses it, not in this one.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
4 tasks
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
## Motivation Follow up for #6351: variables used in the makefile should be defined where they are used if possible. Specifically I moved `EXE` and `ULIMIT` from `Makefile-libs.Inc` to `Makefile`.
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
## Motivation Follow up for #6351: variables used in the makefile should be defined where they are used if possible. Specifically I moved `EXE` and `ULIMIT` from `Makefile-libs.Inc` to `Makefile`.
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
## Motivation Follow up for #6351: variables used in the makefile should be defined where they are used if possible. Specifically I moved `EXE` and `ULIMIT` from `Makefile-libs.Inc` to `Makefile`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix the windows build output
Description
Add on the Makefile-libs.Inc the EXE := .exe
If the GOOS is equal to windows will force the value of EXE = .exe
Test Plan
Check on the release if the .exe was added on the artifacts.
I tested the behavior on other Github Repo.
TODO